Allon Mureinik has posted comments on this change.
Change subject: core: rename DiskImage method to a more clear name
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Looks good to me, pending acks from frontend and rest maintainers to approve
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java
Line 28: import com.google.gwt.user.client.ui.Image;
Line 29: import com.google.gwt.user.client.ui.TreeItem;
Line 30:
Line 31: public class DisksTree extends
AbstractSubTabTree<TemplateDiskListModel, DiskImage, StorageDomain> {
Line 32:
There seems to be some formatting noise in this class - perhaps it's worthwhile
to clear it up
Line 33: ApplicationResources resources;
Line 34: ApplicationConstants constants;
Line 35:
Line 36: public DisksTree(ApplicationResources resources,
ApplicationConstants constants, ApplicationTemplates templates) {
--
To view, visit http://gerrit.ovirt.org/14768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf26bda8e00c1ae2f12b1decf6e1b4a8d12bed31
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
