Tal Nisan has posted comments on this change. Change subject: core: rename methods in DiskImage ......................................................................
Patch Set 4: Looks good to me, approved (1 inline comment) Looks like DisksTree.java was formatted for no apparent reason, no biggy but you might wanna check what happened there .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java Line 56: addValueLabelToPanel(panel, new EnumLabel<VolumeType>(), disk.getVolumeType(), "120px"); //$NON-NLS-1$ Line 57: addValueLabelToPanel(panel, new EnumLabel<DiskInterface>(), disk.getDiskInterface(), "120px"); //$NON-NLS-1$ Line 58: addValueLabelToPanel(panel, new DateLabel(), disk.getCreationDate(), "90px"); //$NON-NLS-1$ Line 59: TreeItem treeItem = new TreeItem(panel); Line 60: treeItem.setUserObject(disk.getId()); Seems like some of the lines were formatted for no reason? Line 61: return treeItem; Line 62: } Line 63: Line 64: @Override -- To view, visit http://gerrit.ovirt.org/14768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf26bda8e00c1ae2f12b1decf6e1b4a8d12bed31 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
