Yair Zaslavsky has posted comments on this change.
Change subject: engine : Persist all async task place holders
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 296: getReturnValue().setDescription((tempVar != null) ? tempVar :
getReturnValue().getDescription());
Line 297: return _returnValue;
Line 298: }
Line 299:
Line 300: boolean actionAllowed = false;
private? protected ? why package?
Line 301:
Line 302: protected void checkCanDoAction() {
Line 303: actionAllowed = getReturnValue().getCanDoAction() ||
internalCanDoAction();
Line 304: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
Line 29: super.setVmTemplateId(parameters.getVmTemplateId());
Line 30: super.setVmTemplateName(parameters.getVmTemplateName());
Line 31: }
Line 32:
Line 33: Guid taskId;
This should be private/protected ?
Line 34: protected void insertAsyncTaskPlaceHolders() {
Line 35: taskId = createAsyncTask(VdcActionType.AddVmTemplate,
Line 36: VdcObjectType.Storage,
Line 37: getParameters().getStorageDomainId(),
--
To view, visit http://gerrit.ovirt.org/14819
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd4a377c3be055c48357881f731f7d1c01c3cb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
