Ravi Nori has posted comments on this change.

Change subject: engine : Persist all async task place holders
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
Line 52:                 
ImagesHandler.getAllImageSnapshots(getDiskImage().getImageId(), 
getDiskImage().getImageTemplateId()));
Line 53: 
Line 54:         
setDiskImage(getDiskImage().getSnapshots().get(getDiskImage().getSnapshots().size()
 - 1));
Line 55:         DiskImage newImage = cloneDiskImage(getDestinationImageId());
Line 56:         fillVolumeInformation(newImage);
Before we call createTask we are calling runVdsCommand which returns 
VDSReturnValue.

>From VDSReturnValue we get AsyncTaskCreationInfo which contains the vdsm task 
>id
Line 57: 
Line 58:         getReturnValue().getAsyncTaskIdList().add(taskId);
Line 59: 
Line 60:         VDSReturnValue vdsReturnValue = Backend


--
To view, visit http://gerrit.ovirt.org/14819
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd4a377c3be055c48357881f731f7d1c01c3cb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to