Ravi Nori has posted comments on this change. Change subject: engine : Persist all async task place holders ......................................................................
Patch Set 3: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java Line 52: ImagesHandler.getAllImageSnapshots(getDiskImage().getImageId(), getDiskImage().getImageTemplateId())); Line 53: Line 54: setDiskImage(getDiskImage().getSnapshots().get(getDiskImage().getSnapshots().size() - 1)); Line 55: DiskImage newImage = cloneDiskImage(getDestinationImageId()); Line 56: fillVolumeInformation(newImage); createTask in CommandBase (after this patch is moved to the front) will create the concreateTask and the the vdsm id for the task and update the row in the database Line 57: Line 58: getReturnValue().getAsyncTaskIdList().add(taskId); Line 59: Line 60: VDSReturnValue vdsReturnValue = Backend .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java Line 170: command.getActionType(), Line 171: command.isInternalExecution()); Line 172: } Line 173: ThreadLocalParamsContainer.setCorrelationId(command.getCorrelationId()); Line 174: command.checkCanDoAction(); The method might be a bit misleading, even with the original code we are still performing actionAllowed = getReturnValue().getCanDoAction() || internalCanDoAction(); in executeAction method. The actionAllowed variable that is global now is false and if we dont call the checkCanDoAction it will be false and executeAction will not run Line 175: command.insertAsyncTaskPlaceHolders(); Line 176: command.executeAction(); Line 177: } Line 178: -- To view, visit http://gerrit.ovirt.org/14819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bdd4a377c3be055c48357881f731f7d1c01c3cb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
