Omer Frenkel has posted comments on this change.

Change subject: Validate installed host by requesting for vdsm uuid
......................................................................


Patch Set 3: No score

>I tend not to update config file if the defaults at ConfigValues are good and 
>probably not to be modified ever.
..
>In the field we can always add a value into vdc_option to alter behavior.

i think in the field the engine-config is used with an altered file, not sure 
if it would work without a matching row in the db.

yair?

> Regarding version specific... when you install a host to a specific cluster 
> level it does not mean that the vdsm at target is not newer than that level, 
> so the dependency in cluster level version will probably not be productive, 
> no?

i agree, when you add host to a cluster you cant assume anything on the host 
added.

--
To view, visit http://gerrit.ovirt.org/14905
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c6c0a85daba47fabb9253963ff187a670f28ae6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to