Yair Zaslavsky has posted comments on this change. Change subject: Validate installed host by requesting for vdsm uuid ......................................................................
Patch Set 3: Some comments - A. Not including the relevant entries at vdc_options will cause warnings at log - we already got several bugs of "please eliminate the above warning" - We can debate about the architecture of config, but this is the current situation , until we change it. B. The cluster/version issue - when we install a host at cluster (let's say 3.1) we can safely assume it conforms to "vdsm api" for 3.1 - this is how engine behaves with all VDSM related issues (see 0000_config.sql and see all entries with "XXXEnabled" names. I would prefer we currently stick to this behavior, if possible. -- To view, visit http://gerrit.ovirt.org/14905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c6c0a85daba47fabb9253963ff187a670f28ae6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
