Yaniv Bronhaim has posted comments on this change. Change subject: Validate installed host by requesting for vdsm uuid ......................................................................
Patch Set 5: We've already have enough config values that don't exist in vdc_options table, if we decide to stick with adding all them to DB we should do it to all parameters. Util then, as most of the values that doesn't exist in DB, "vdsm-tool" value can skip the DB part as we don't want to allow modifying it (I would prefer hard-coded constant if we don't want to avoid the warning). For the cluster condition, we can add it just to avoid redundant calls to old version of vdsm that doesn't support the command, but even if we send the request to old vdsm, the returned error won't hurt us. IMO, Adding more cluster conditions just make the code more clumsy if it's not needed . -- To view, visit http://gerrit.ovirt.org/14905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c6c0a85daba47fabb9253963ff187a670f28ae6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
