Alon Bar-Lev has posted comments on this change. Change subject: packaging: Updated otopi for fully automated execution ......................................................................
Patch Set 2: (3 inline comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/apache/root.py Line 103: ) Line 104: Line 105: self.environment[ Line 106: osetupcons.ApacheEnv.CONFIGURE_ROOT_REDIRECTION Line 107: ] = self._enabled I prefer you use some other variable or even use the environment explicitly above... and then set _enabled. So we do not have mistakes in future in which _enabled has several usages. Line 108: Line 109: @plugin.event( Line 110: stage=plugin.Stages.STAGE_MISC, Line 111: condition=lambda self: self._enabled, .................................................... File packaging/setup/plugins/ovirt-engine-setup/apache/ssl.py Line 146 Line 147 Line 148 Line 149 Line 150 Just remove the else. Line 148: default=True, Line 149: ) Line 150: self.environment[ Line 151: osetupcons.ApacheEnv.CONFIGURE_SSL Line 152: ] = self._enabled I prefer you use some other variable or even use the environment explicitly above... and then set _enabled. So we do not have mistakes in future in which _enabled has several usages. Line 153: else: Line 154: self._enabled = self.environment[ Line 155: osetupcons.ApacheEnv.CONFIGURE_SSL Line 156: ] -- To view, visit http://gerrit.ovirt.org/14985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia327a4be9e1f5498e6aedc7dfb66663dd861fc26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
