Sandro Bonazzola has posted comments on this change. Change subject: packaging: Updated otopi for fully automated execution ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/config/iso_domain.py Line 253: while not validDomain: Line 254: try: Line 255: if self.environment[ Line 256: osetupcons.ConfigEnv.ISO_DOMAIN_NFS_MOUNT_POINT Line 257: ] is None: this will not ask again for mount point if it fails validation Line 258: default_mount_point = self.environment[ Line 259: osetupcons.ConfigEnv.ISO_DOMAIN_DEFAULT_NFS_MOUNT_POINT Line 260: ] Line 261: if os.path.exists(default_mount_point): Line 282: ) Line 283: Line 284: validDomain = True Line 285: Line 286: except (ValueError, RuntimeError) as e: you should reset to None ISO_DOMAIN_NFS_MOUNT_POINT here then. Line 287: if interactive: Line 288: self.logger.error( Line 289: _( Line 290: 'Cannot access mount point ' -- To view, visit http://gerrit.ovirt.org/14985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia327a4be9e1f5498e6aedc7dfb66663dd861fc26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
