Sandro Bonazzola has posted comments on this change. Change subject: packaging: Updated otopi for fully automated execution ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/config/iso_domain.py Line 293: mountPoint=self.environment[ Line 294: osetupcons.ConfigEnv.ISO_DOMAIN_NFS_MOUNT_POINT Line 295: ], Line 296: error=e, Line 297: ) if you don't want an endless loop in interactive mode when validation fails you should also add: self.environment[osetupcons.ConfigEnv.ISO_DOMAIN_NFS_MOUNT_POINT] = None here Line 298: ) Line 299: else: Line 300: raise Line 301: -- To view, visit http://gerrit.ovirt.org/14985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia327a4be9e1f5498e6aedc7dfb66663dd861fc26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
