Daniel Erez has posted comments on this change.
Change subject: core: introducing virtio-scsi support
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/dbscripts/upgrade/03_03_0170_add_permission_to_configure_sgio.sql
Line 1: -- Add CONFIGURE_SCSI_GENERIC_IO action_group to DataCenterAdmin role
Line 2: select
fn_db_add_action_group_to_role('def00002-0000-0000-0000-def000000002', 1105);
Line 3: -- Add CONFIGURE_SCSI_GENERIC_IO action_group to SuperUser role
Line 4: select
fn_db_add_action_group_to_role('00000000-0000-0000-0000-000000000001', 1105);
1. none of them seem relevant:
- 'disk owner': I guess you mean 'Disk Creator' which is a user role.
- 'vm admin': I guess you mean 'VmPoolAdmin' which is not related to disk perms.
- 'template admin' - can't create/edit disks
2. deserves a separate script imo... (can combine with add sgio column script).
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 172: select fn_db_add_config_value('VirtIoScsiEnabled','false','3.0');
Line 173: select fn_db_add_config_value('VirtIoScsiEnabled','false','3.1');
Line 174: select fn_db_add_config_value('VirtIoScsiEnabled','false','3.2');
Line 175: select fn_db_add_config_value('VirtIoScsiEnabled','true','3.3');
Line 176: select
fn_db_add_config_value('VirtIoScsiUnsupportedOsList','WindowsXP,RHEL5,RHEL5x64,RHEL4,RHEL4x64,RHEL3,RHEL3x64','general');
Same as HotPlugUnsupportedOsList config value:
I don't want to edit it every time a new OS comes out.
Line 177:
Line 178: -- by default use no proxy
Line 179: select fn_db_add_config_value('SpiceProxyDefault','','general');
Line 180:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 151:
Line 152: return true;
Line 153: }
Line 154:
Line 155: protected boolean isOsSupportedForVirtIoScsi() {
why? it's similar to 'isVersionSupportedForShareable'
Line 156: String vmOs = getVm().getOs().name();
Line 157: String[] unsupportedOSs = Config.<String>
GetValue(ConfigValues.VirtIoScsiUnsupportedOsList).split(",");
Line 158: for (String os : unsupportedOSs) {
Line 159: if (os.equalsIgnoreCase(vmOs)) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 136: @Override
Line 137: public boolean eval(T a) {
Line 138: return a.getDiskInterface() ==
DiskInterface.VirtIO_SCSI;
Line 139: }
Line 140: }).isEmpty() ? 0 : 1;
No, one controller can serve up to 256 disks.
Line 141:
Line 142: if (pciInUse > MAX_PCI_SLOTS) {
Line 143: result = false;
Line 144:
messages.add(VdcBllMessages.ACTION_TYPE_FAILED_EXCEEDED_MAX_PCI_SLOTS.name());
--
To view, visit http://gerrit.ovirt.org/14906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie572b8106b3fe5becec69c140546db81bc671c96
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
