Daniel Erez has posted comments on this change.
Change subject: core: introducing virtio-scsi support
......................................................................
Patch Set 1: (7 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 127: protected void updateDisksFromDb() {
Line 128: VmHandler.updateDisksFromDb(getVm());
Line 129: }
Line 130:
Line 131: protected boolean validateVirtIoScsi(Disk oldDisk, Disk newDisk) {
I know, it's a bit confusing but it's simpler... I'll try to refactor it a bit
differently.
Line 132: if (DiskInterface.VirtIO_SCSI != newDisk.getDiskInterface()) {
Line 133: return true;
Line 134: }
Line 135:
Line 154:
Line 155: protected boolean isOsSupportedForVirtIoScsi() {
Line 156: String vmOs = getVm().getOs().name();
Line 157: String[] unsupportedOSs = Config.<String>
GetValue(ConfigValues.VirtIoScsiUnsupportedOsList).split(",");
Line 158: for (String os : unsupportedOSs) {
The values aren't necessarily in lower/upper case.
Line 159: if (os.equalsIgnoreCase(vmOs)) {
Line 160:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_GUEST_OS_VERSION_IS_NOT_SUPPORTED);
Line 161: return false;
Line 162: }
Line 164: return true;
Line 165: }
Line 166:
Line 167: protected boolean isVersionSupportedForVirtIoScsi(Disk disk,
String clusterVersion) {
Line 168: return Config.<Boolean>
GetValue(ConfigValues.VirtIoScsiEnabled, clusterVersion);
Done
Line 169: }
Line 170:
Line 171: protected boolean isVersionSupportedForShareable(Disk disk,
String compVersion) {
Line 172: if (disk.getDiskStorageType() == DiskStorageType.IMAGE) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1337: @DefaultValueAttribute("false")
Line 1338: VirtIoScsiEnabled(505),
Line 1339:
Line 1340: @Reloadable
Line 1341: @TypeConverterAttribute(String.class)
Done
Line 1342: @DefaultValueAttribute("")
Line 1343: VirtIoScsiUnsupportedOsList(506),
Line 1344:
Line 1345: Invalid(65535);
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 84: MigrationSupportForNativeUsb(ConfigAuthType.User),
Line 85: MigrationNetworkEnabled,
Line 86: VncKeyboardLayout(ConfigAuthType.User),
Line 87: VncKeyboardLayoutValidValues(ConfigAuthType.User),
Line 88: VirtIoScsiEnabled(ConfigAuthType.User),
Done
Line 89: ;
Line 90:
Line 91: public static enum ConfigAuthType {
Line 92: Admin,
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 757: SHAREABLE_DISK_IS_NOT_SUPPORTED_FOR_DISK=Cannot ${action} ${type}.
Disk cannot be shareable if it depends on a snapshot. In order to share it,
remove the disk's snapshots.
Line 758: SHAREABLE_DISK_IS_NOT_SUPPORTED_BY_VOLUME_FORMAT=Cannot ${action}
${type}. Disk's volume format is not supported for shareable disk.
Line 759: ERROR_CANNOT_DETACH_DISK_WITH_SNAPSHOT=Cannot ${action} ${type}. The
disk is already configured in a snapshot. In order to detach it, remove the
disk's snapshots.
Line 760: DISK_IS_ALREADY_SHARED_BETWEEN_VMS=Cannot ${action} ${type}. Disk is
shared between vms and cannot become unshareable . Detach the disk from the
rest of the vms it is attached to and then update the disk to be unshareable.
Line 761: SCSI_GENERIC_IO_IS_NOT_SUPPORTED_FOR_IMAGE_DISk="Cannot ${action}
${type}. SCSI Generic IO is not supported for image disk."
Done
Line 762:
Line 763: #Suspected (not in use?)
Line 764: USER_PASSWORD_EXPIRED=Cannot Login. User Password has expired, Please
change your password.
Line 765: USER_CANNOT_LOGIN_DOMAIN_NOT_SUPPORTED=Cannot Login. The Domain
provided is not configured, please contact your system administrator.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 300: struct.put(VdsProperties.Type,
VmDeviceType.CONTROLLER.getName());
Line 301: struct.put(VdsProperties.Device, VdsProperties.Scsi);
Line 302: struct.put(VdsProperties.Model, VdsProperties.VirtioScsi);
Line 303: devices.add(struct);
Line 304: }
We don't have tests for VmInfoBuilder
Line 305: }
Line 306:
Line 307: @Override
Line 308: protected void buildVmNetworkInterfaces() {
--
To view, visit http://gerrit.ovirt.org/14906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie572b8106b3fe5becec69c140546db81bc671c96
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
