Allon Mureinik has posted comments on this change.
Change subject: core: introducing virtio-scsi support
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 143: }
Line 144:
Line 145: private boolean checkIfImageDiskCanBeAdded(VM vm) {
Line 146: boolean returnValue;
Line 147: DiskValidator diskValidator = new
DiskValidator(getParameters().getDiskInfo());
I'd extract a createDiskValidator() method, but it's really a matter of taste
Line 148:
Line 149: // vm agnostic checks
Line 150: returnValue =
Line 151: validate(new
StorageDomainValidator(getStorageDomain()).isDomainExistAndActive()) &&
--
To view, visit http://gerrit.ovirt.org/14906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie572b8106b3fe5becec69c140546db81bc671c96
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
