Alon Bar-Lev has posted comments on this change.
Change subject: engine: Allow engine to configure management network
......................................................................
Patch Set 12: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 92: private boolean _goingToReboot = false;
Line 93: private boolean _aborted = false;
Line 94: private boolean _installIncomplete = false;
Line 95: private String _managementNetwork = null;
Line 96: private DeployStatus deployStatus = DeployStatus.Failed;
can you please rename to _deployStatus? I missed that.
Line 97:
Line 98: private String _certificate;
Line 99: private String _iptables = "";
Line 100:
Line 402: VdsmEnv.MANAGEMENT_BRIDGE_NAME,
Line 403: _managementNetwork
Line 404: );
Line 405: }
Line 406: else if (_isNode) {
Livnat asked that the old node workaround will not be reflected in application
logic.
The other way to do that is to remove the br* bridge at network setup, but this
was rejected.
Line 407: _parser.cliEnvironmentSet(
Line 408: VdsmEnv.MANAGEMENT_BRIDGE_NAME,
Line 409: NetworkUtils.getEngineNetwork()
Line 410: );
Line 840: *
Line 841: * @param managementNetwork
Line 842: */
Line 843: public void setManagementNetwork(String managementNetwork) {
Line 844: this._managementNetwork = managementNetwork;
right :)
Line 845: }
Line 846:
Line 847: public void setCorrelationId(String correlationId) {
Line 848: _correlationId = correlationId;
--
To view, visit http://gerrit.ovirt.org/14230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Martin Pavlik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
