Moti Asayag has posted comments on this change.
Change subject: engine: Allow engine to configure management network
......................................................................
Patch Set 10: (1 inline comment)
I meant later on today :-)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 941: "Installation failed, please refer to
installation logs"
Line 942: );
Line 943: }
Line 944: else if (_goingToReboot) {
Line 945: _vds.setStatus(VDSStatus.Reboot);
Wouldn't adding InstallationStatus enum with values of "Rebooting", "Failed"
and "Completed" and exposing "Vds.getInstallationStatus()" that we can use in
switch block will be better ? this way it could be extended easily if new
installation statuses will be added, rather than adding more and more getters.
Line 946: }
Line 947: else if (_installIncomplete) {
Line 948: _vds.setStatus(VDSStatus.InstallFailed);
Line 949: }
--
To view, visit http://gerrit.ovirt.org/14230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Martin Pavlik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
