Moti Asayag has posted comments on this change.

Change subject: engine: Allow engine to configure management network
......................................................................


Patch Set 10: (1 inline comment)

I'll send a newer version later on to isolate the host statuses from within the 
VdsDeploy.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 273:      * @param status
Line 274:      *            new status.
Line 275:      */
Line 276:     private void setVdsStatus(VDSStatus status) {
Line 277:         runVdsCommand(VDSCommandType.SetVdsStatus, new 
SetVdsStatusVDSCommandParameters(getVdsId(), status));
right, the status will be updated each time this method is called

you can see the implementation within 
org.ovirt.engine.core.vdsbroker.SetVdsStatusVDSCommand
Line 278:     }
Line 279: 
Line 280:     private boolean isOvirtReInstallOrUpgrade() {
Line 281:         return getParameters().getIsReinstallOrUpgrade() && 
getVds().getVdsType() == VDSType.oVirtNode;


--
To view, visit http://gerrit.ovirt.org/14230
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Martin Pavlik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to