Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: unify new server/desktop to newVm
......................................................................
Patch Set 5: (12 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 199:
Line 200: @UiField(provided = true)
Line 201: @Path(value = "isSoundcardEnabled.entity")
Line 202: @WithElementId("isSoundcardEnabled")
Line 203: public EntityModelCheckBoxEditor isSoundcardEnabledEditor;
related to this patch?
Line 204:
Line 205: // == Pools ==
Line 206: @UiField
Line 207: protected DialogTab poolTab;
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmClonePopupWidget.java
Line 37
Line 38
Line 39
Line 40
Line 41
isn't it still needed for clone vm dialog?
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 608: new StoragePoolQueryParametersBase(dataCenterId),
Line 609: aQuery);
Line 610: }
Line 611:
Line 612: public static void isSoundcardEnabled(AsyncQuery aQuery, Guid
vmId) {
not sure if it's related to the unification, probably should be in a separate
patch...
Line 613: aQuery.converterCallback = new IAsyncConverter() {
Line 614: @Override
Line 615: public Object Convert(Object source, AsyncQuery
_asyncQuery) {
Line 616: if (source != null) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java
Line 449
Line 450
Line 451
Line 452
Line 453
still used by TemplateGeneralModelForm
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
Line 76:
model.setDataCentersAndClusters(model,
Line 77:
Arrays.asList(dataCenter),
Line 78: clusters,
Line 79:
vm.getVdsGroupId().getValue());
Line 80:
AsyncDataProvider.isSoundcardEnabled(new AsyncQuery(getModel(),
* same - not sure how relevant to the unification, sound card should probably
be extracted to a separate patch.
* if not dependent, isSoundcardEnabled can be called in parallel of
getClusterListByService.
Line 81: new
INewAsyncCallback() {
Line 82:
Line 83: @Override
Line 84: public void
onSuccess(Object model, Object returnValue) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1274: else if
(ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition))
Line 1275: {
Line 1276: if (sender == getVmType()) {
Line 1277: vmTypeChanged();
Line 1278: } else if (sender == getDataCenterWithClustersList())
formatter
Line 1279: {
Line 1280: dataCenterWithClusterSelectedItemChanged(sender,
args);
Line 1281: initUsbPolicy();
Line 1282: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
Line 603:
Line 604: translator = EnumTranslator.Create(OriginType.class);
Line 605: setOrigin(translator.get(vm.getOrigin()));
Line 606:
Line 607: setHasHighlyAvailable(true);
isn't it related to VmType anymore?
Line 608: setIsHighlyAvailable(vm.isAutoStartup());
Line 609:
Line 610: setHasPriority(true);
Line 611:
setPriority(AsyncDataProvider.priorityToString(vm.getPriority()));
Line 606:
Line 607: setHasHighlyAvailable(true);
Line 608: setIsHighlyAvailable(vm.isAutoStartup());
Line 609:
Line 610: setHasPriority(true);
same
Line 611:
setPriority(AsyncDataProvider.priorityToString(vm.getPriority()));
Line 612:
Line 613: setHasMonitorCount(true);
Line 614: setMonitorCount(vm.getNumOfMonitors());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
Line 393:
Line 394: consoleModelsCache = new ConsoleModelsCache(this);
Line 395: setConsoleHelpers();
Line 396:
Line 397: setNewVmCommand(new UICommand("NewVM", this)); //$NON-NLS-1$
redundant
Line 398: setNewVmCommand(new UICommand("NewVm", this)); //$NON-NLS-1$
Line 399: setEditCommand(new UICommand("Edit", this)); //$NON-NLS-1$
Line 400: setRemoveCommand(new UICommand("Remove", this)); //$NON-NLS-1$
Line 401: setRunCommand(new UICommand("Run", this, true)); //$NON-NLS-1$
Line 699:
Line 700: UnitVmModel model = new UnitVmModel(new NewVmModelBehavior());
Line 701: model.setTitle(ConstantsManager.getInstance()
Line 702: .getMessages()
Line 703:
.newVmTitle(ConstantsManager.getInstance().getConstants().vm()));
message can be simply converted to a constant:
s/New {0} Virtual Machine/New Virtual Machine
Line 704: model.setHashName("new_vm"); //$NON-NLS-1$
Line 705: model.setIsNew(true);
Line 706: model.getVmType().setSelectedItem(VmType.Server);
Line 707:
model.setCustomPropertiesKeysList(getCustomPropertiesKeysList());
Line 770: model.setVmAttachedToPool(vm.getVmPoolId() != null);
Line 771: setWindow(model);
Line 772: model.setTitle(ConstantsManager.getInstance()
Line 773: .getMessages()
Line 774:
.editVmTitle(ConstantsManager.getInstance().getConstants().vm()));
message can be simply converted to a constant:
s/Edit {0} Virtual Machine/Edit Virtual Machine
Line 775: model.setHashName("edit_vm"); //$NON-NLS-1$
Line 776:
model.setCustomPropertiesKeysList(getCustomPropertiesKeysList());
Line 777:
Line 778: model.initialize(this.getSystemTreeSelectedItem());
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 1310:
Line 1311: @DefaultStringValue("Uptime")
Line 1312: String uptimeVm();
Line 1313:
Line 1314: @DefaultStringValue("New Vm")
s/Vm/VM
Line 1315: String newVm();
Line 1316:
Line 1317: @DefaultStringValue("Edit")
Line 1318: String editVm();
--
To view, visit http://gerrit.ovirt.org/15048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcb7065e2968a84fef30951e8a45019ea1095520
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
