Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: unify new server/desktop to newVm ......................................................................
Patch Set 6: Looks good to me, approved (1 inline comment) one last comment.. .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java Line 575: setIsHighlyAvailable(vm.isAutoStartup()); Line 576: Line 577: setPriority(AsyncDataProvider.priorityToString(vm.getPriority())); Line 578: Line 579: setHasMonitorCount(true); please check if this one can be removed as well.. Line 580: setMonitorCount(vm.getNumOfMonitors()); Line 581: Line 582: setHasUsbPolicy(true); Line 583: translator = EnumTranslator.Create(UsbPolicy.class); -- To view, visit http://gerrit.ovirt.org/15048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcb7065e2968a84fef30951e8a45019ea1095520 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
