Itamar Heim has posted comments on this change.
Change subject: userportal,webadmin: unify new server/desktop to newVm
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 199:
Line 200: @UiField(provided = true)
Line 201: @Path(value = "isSoundcardEnabled.entity")
Line 202: @WithElementId("isSoundcardEnabled")
Line 203: public EntityModelCheckBoxEditor isSoundcardEnabledEditor;
related. servers don't have audio and desktops do today. we won't to lose this
distinction and allow to edit this option
Line 204:
Line 205: // == Pools ==
Line 206: @UiField
Line 207: protected DialogTab poolTab;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
Line 603:
Line 604: translator = EnumTranslator.Create(OriginType.class);
Line 605: setOrigin(translator.get(vm.getOrigin()));
Line 606:
Line 607: setHasHighlyAvailable(true);
this patch is exactly about removing the notion of VmType and allowing HA and
audio in any case (with "optimize for server/desktop" to suggest values, but
allow to configure them
Line 608: setIsHighlyAvailable(vm.isAutoStartup());
Line 609:
Line 610: setHasPriority(true);
Line 611:
setPriority(AsyncDataProvider.priorityToString(vm.getPriority()));
--
To view, visit http://gerrit.ovirt.org/15048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcb7065e2968a84fef30951e8a45019ea1095520
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
