Alissa Bonas has posted comments on this change. Change subject: core: add validation non empty connection field ......................................................................
Patch Set 2: Verified The validation code is duplicated in add and update commands since they inherit from different base classes, thus the common code cannot be placed in the parent class in order to benefit code reuse. If you have any idea how to nicely reuse it (or maybe if the class hierarchy can be changed for AddStorageServerConnection - it seems to be the odd one) - please speak. -- To view, visit http://gerrit.ovirt.org/15560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d9d133faa54e74a9c4c14a93edb6bd16a9ee796 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
