Sergey Gotliv has posted comments on this change. Change subject: core: add validation non empty connection field ......................................................................
Patch Set 2: Looks good to me, but someone else must approve I have a few thoughts that I want to share. These tests validate failure of canDoAction with specific error message. I assume that if someone changes the message or just order of conditions in caDoAction this test will fail even the flow is still valid. In both cases I mentioned before, developer have to do additional work to fix these tests. I think validator that will check connection emptiness may be better... -- To view, visit http://gerrit.ovirt.org/15560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d9d133faa54e74a9c4c14a93edb6bd16a9ee796 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
