Yaniv Bronhaim has posted comments on this change.
Change subject: core: Adds config of command to restart VDSM by SSH
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
Adding the command to ConfigValues and 0000_config.sql is enough. I don't think
we want to add it to engine-config as we don't want the user to modify this
command.
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 556: select fn_db_add_config_value('CustomDeviceProperties', '', '3.1');
Line 557: select fn_db_add_config_value('CustomDeviceProperties', '', '3.2');
Line 558: select fn_db_add_config_value('CustomDeviceProperties', '', '3.3');
Line 559:
Line 560: select fn_db_add_config_value('RestartVdsmBySshCommand', 'service
vdsmd restart', '3.0');
please use "/sbin/service"
Line 561: select fn_db_add_config_value('RestartVdsmBySshCommand', 'service
vdsmd restart', '3.1');
Line 562: select fn_db_add_config_value('RestartVdsmBySshCommand', 'service
vdsmd restart', '3.2');
Line 563: select fn_db_add_config_value('RestartVdsmBySshCommand',
'/usr/bin/vdsm-tool service-restart vdsmd', '3.3');
Line 564:
....................................................
File packaging/etc/engine-config/engine-config.properties
Line 272: GlusterRefreshRateHooks.description="Refresh rate (in seconds) of
gluster hooks from gluster servers"
Line 273: GlusterRefreshRateHooks.type=Integer
Line 274: GlusterRefreshRateHooks.validValues=30..3600
Line 275: RestartVdsmBySshCommand.description="Command that restarts VDSM on
host using SSH connection"
Line 276: RestartVdsmBySshCommand.type=String
I don't think this value should be configurable by engine-config. Only manual
DB modification should change the command (as the other hardcoded commands) if
we really want to perform a change.
--
To view, visit http://gerrit.ovirt.org/15797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f96cbe0c5fdc33f8f512c36d1cd85349852f2da
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
