Yaniv Bronhaim has posted comments on this change. Change subject: core: Adds config of command to restart VDSM by SSH ......................................................................
Patch Set 3: (1 inline comment) .................................................... File packaging/etc/engine-config/engine-config.properties Line 272: GlusterRefreshRateHooks.description="Refresh rate (in seconds) of gluster hooks from gluster servers" Line 273: GlusterRefreshRateHooks.type=Integer Line 274: GlusterRefreshRateHooks.validValues=30..3600 Line 275: RestartVdsmBySshCommand.description="Command that restarts VDSM on host using SSH connection" Line 276: RestartVdsmBySshCommand.type=String could be useful, but it wasn't the requirement and the command's meaning. in this patch we intend to want only vdsm restart remote command. if we would want configurable soft fence command it would be something else, and we should change the command's name -- To view, visit http://gerrit.ovirt.org/15797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f96cbe0c5fdc33f8f512c36d1cd85349852f2da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
