Yaniv Bronhaim has posted comments on this change. Change subject: core: Adds config of command to restart VDSM by SSH ......................................................................
Patch Set 4: (1 inline comment) .................................................... File packaging/etc/engine-config/engine-config.properties Line 280: DefaultWindowsTimeZone.description="Default time zone to be used when creating new Windows VMs" Line 281: DefaultWindowsTimeZone.type=String Line 282: DefaultGeneralTimeZone.description="Default time zone to be used when creating Linux and Other-OS VMs" Line 283: DefaultGeneralTimeZone.type=String Line 284: SshSoftFencingCommand.description="Command that restarts VDSM on host using SSH connection" Again, if this description is what the command does, you don't need to include it in engine-config. I prefer to prevent the user from changing it. But if you do want to make it configurable for the user, just change the description - command for soft fetcing before restarting the host, as default its set to restart vdsm deamon. -- To view, visit http://gerrit.ovirt.org/15797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f96cbe0c5fdc33f8f512c36d1cd85349852f2da Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
