Omer Frenkel has posted comments on this change.
Change subject: core, restapi, webadmin, userportal: cloud-init [3/6] - backend
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java
Line 72: storeExecutionParameters();
Line 73:
Line 74: String metaDataStr = mapToJson(metaData);
Line 75: String userDataStr = mapToYaml(userData);
Line 76: log.debugFormat("cloud-init meta-data:\n" + metaDataStr);
this might be a problem if it stores the password in plain text, we wouldn't
want it logged even in debug, i guess
Line 77: log.debugFormat("cloud-init user-data:\n" + userDataStr);
Line 78: files.put("openstack/latest/meta_data.json",
metaDataStr.getBytes("UTF-8"));
Line 79: files.put("openstack/latest/user_data",
userDataStr.getBytes("UTF-8"));
Line 80:
--
To view, visit http://gerrit.ovirt.org/14350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida8ffa5b92ff79cdac5e401c0a815ffcf517590d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
