Greg Padgett has posted comments on this change.
Change subject: core, restapi, webadmin, userportal: cloud-init [3/6] - backend
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java
Line 72: storeExecutionParameters();
Line 73:
Line 74: String metaDataStr = mapToJson(metaData);
Line 75: String userDataStr = mapToYaml(userData);
Line 76: log.debugFormat("cloud-init meta-data:\n" + metaDataStr);
@Omer re: logging the password: As discussed earlier, a good point. The change
is not in the latest patch.
Line 77: log.debugFormat("cloud-init user-data:\n" + userDataStr);
Line 78: files.put("openstack/latest/meta_data.json",
metaDataStr.getBytes("UTF-8"));
Line 79: files.put("openstack/latest/user_data",
userDataStr.getBytes("UTF-8"));
Line 80:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 157: if (!vmDevice.getIsManaged()) {
Line 158: continue;
Line 159: }
Line 160: // ignore additional cd devices if a cloud-init
payload device is used
Line 161: if (!VmPayload.isPayload(vmDevice.getSpecParams()) &&
vmDevices.size() > 1 && vm.isCloudInitUsed()) {
@Oved, Omer re: bug for multiple devices: suggested change made, but not yet
tested.
Line 162: continue;
Line 163: }
Line 164: struct = new HashMap<String, Object>();
Line 165: String cdPath = vm.getCdPath();
--
To view, visit http://gerrit.ovirt.org/14350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida8ffa5b92ff79cdac5e401c0a815ffcf517590d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
