Martin Betak has posted comments on this change. Change subject: core, restapi, webadmin, userportal: cloud-init [3/6] - backend ......................................................................
Patch Set 2: Actually I like the change because I have prepared some refactoring of timezone handling (needed for engine-config DefaultTimeZone validation + would result in some performance improvements and simplification of TimeZoneModel on the frontend) and the only thing blocking it was that I didn't have this linux timezone map prepared beforehand and you cannot use java.util.TimeZone in GWT code. This change would be a major help in that way. Only thing to consider is if hardcoding the list won't cause problems when the timezone data are updated (from geopolitical resons or such) and will be reflected in java.util.TimeZone but not in our code. -- To view, visit http://gerrit.ovirt.org/14350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida8ffa5b92ff79cdac5e401c0a815ffcf517590d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
