Yair Zaslavsky has posted comments on this change.
Change subject: Wrap validation of fingerprint in each connect using
EngineSSHClient
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 838: */
Line 839: public void execute(AuthenticationMethod auth) throws Exception {
Line 840: InputStream in = null;
Line 841: try {
Line 842: _dialog.connect(_vds);
where is disconnect performed?
Line 843: _messages.post(
Line 844: InstallerMessages.Severity.INFO,
Line 845: String.format(
Line 846: "Connected to host %1$s with SSH key fingerprint:
%2$s",
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtils.java
Line 137: * @return an array of bytes containing the fingerprint of the key
Line 138: */
Line 139: public static final byte[] getKeyFingerprintBytes(final PublicKey
key) {
Line 140: if (key == null) {
Line 141: log.error("Public key is uninitialized, failed to
retreive fingerprint.");
s/uninitilized/null
Line 142: return null;
Line 143: }
Line 144:
Line 145: // Get the serialized version of the key:
--
To view, visit http://gerrit.ovirt.org/16126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01517a153406c8bafc672c20b0bf8686763a2f5
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
