Alon Bar-Lev has posted comments on this change.
Change subject: Wrap validation of fingerprint in each connect using
EngineSSHClient
......................................................................
Patch Set 14: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java
Line 30: * Setting internal vds object
Line 31: */
Line 32: public void setVds(VDS vds) throws Exception {
Line 33: _vds = vds;
Line 34: if (_vds != null) {
I don't care if it is null... the setVds of the EngineSSHClient should fail in
this case or not, depending of what we want.
Line 35: setHost(_vds.getHostName(), _vds.getSshPort());
Line 36: setUser(_vds.getSshUsername());
Line 37: }
Line 38: if (_client != null) {
Line 34: if (_vds != null) {
Line 35: setHost(_vds.getHostName(), _vds.getSshPort());
Line 36: setUser(_vds.getSshUsername());
Line 37: }
Line 38: if (_client != null) {
please do not effect current client. the setVds should have called before.
Line 39: ((EngineSSHClient)_client).setVds(_vds);
Line 40: }
Line 41: }
Line 42:
--
To view, visit http://gerrit.ovirt.org/16126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01517a153406c8bafc672c20b0bf8686763a2f5
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
