Alon Bar-Lev has posted comments on this change.
Change subject: Wrap validation of fingerprint in each connect using
EngineSSHClient
......................................................................
Patch Set 13: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java
Line 74: }
Line 75: if (getSoftTimeout() != 0) {
Line 76: _client.setSoftTimeout(getSoftTimeout());
Line 77: }
Line 78: ((EngineSSHClient)_client).setVds(vds);
again... need to know why the above lies are needed... if I have some
explanation I can try and fix the implementation.
Line 79:
Line 80: log.debug("connecting");
Line 81: _client.connect();
Line 82: }
Line 79:
Line 80: log.debug("connecting");
Line 81: _client.connect();
Line 82: }
Line 83: catch(Exception e) {
not sure we need this extra log.
Line 84: log.debug(
Line 85: String.format(
Line 86: "Could not connect to host %1$s",
Line 87: _client.getDisplayHost()
--
To view, visit http://gerrit.ovirt.org/16126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01517a153406c8bafc672c20b0bf8686763a2f5
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
