Yaniv Bronhaim has posted comments on this change.
Change subject: Wrap validation of fingerprint in each connect using
EngineSSHClient
......................................................................
Patch Set 13: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java
Line 74: }
Line 75: if (getSoftTimeout() != 0) {
Line 76: _client.setSoftTimeout(getSoftTimeout());
Line 77: }
Line 78: ((EngineSSHClient)_client).setVds(vds);
easy to understand. In SSHDialog::connect we do:
1. creating client object
2. setting host\port\timeouts
3. connent
here we do the same but adding the setVds part.
we have 2 options here,
1. do what i did, override connect with vds as parameter and set it to client
after creations.
2. split the connect to initialize part that creates the client object, set
whatever needed, and connect does the connect.
otherwise, I can't use the father's or avoiding override.
Line 79:
Line 80: log.debug("connecting");
Line 81: _client.connect();
Line 82: }
Line 79:
Line 80: log.debug("connecting");
Line 81: _client.connect();
Line 82: }
Line 83: catch(Exception e) {
might be redundant, ill remove the print
Line 84: log.debug(
Line 85: String.format(
Line 86: "Could not connect to host %1$s",
Line 87: _client.getDisplayHost()
--
To view, visit http://gerrit.ovirt.org/16126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01517a153406c8bafc672c20b0bf8686763a2f5
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
