Moti Asayag has posted comments on this change.

Change subject: [WIP] core: Add vnic profiles to DB and entities
......................................................................


Patch Set 11: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterfaceProfile.java
Line 6: import org.ovirt.engine.core.compat.Guid;
Line 7: 
Line 8: import java.io.Serializable;
Line 9: 
Line 10: public class VmNetworkInterfaceProfile extends IVdcQueryable 
implements Serializable, BusinessEntity<Guid>, Nameable {
shouldn't the vnic profile include also a field of the network QoS ID ?
Line 11: 
Line 12:     private String name;
Line 13:     private Guid id;
Line 14:     private Network network;


-- 
To view, visit http://gerrit.ovirt.org/15992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0525a6d30995fe896499fed283638b93cae5e41
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to