Moti Asayag has posted comments on this change. Change subject: [WIP] core: Add vnic profiles to DB and entities ......................................................................
Patch Set 12: (3 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java Line 105: CONFIGURE_SCSI_GENERIC_IO(1105, RoleType.ADMIN, VdcObjectType.Disk, true, ApplicationMode.VirtOnly), Line 106: Line 107: // Network Line 108: PORT_MIRRORING(1200, RoleType.ADMIN, VdcObjectType.Network, true, ApplicationMode.VirtOnly), Line 109: CONFIGURE_NETWORK_VNIC_PROFILE(1203, RoleType.ADMIN, VdcObjectType.Network, true), the subject entity should VnicProfile rather than Network Line 110: CREATE_NETWORK_VNIC_PROFILE(1204, RoleType.ADMIN, VdcObjectType.Network, true), Line 111: DELETE_NETWORK_VNIC_PROFILE(1205, RoleType.ADMIN, VdcObjectType.Network, true), Line 112: Line 113: // Login action group Line 107: // Network Line 108: PORT_MIRRORING(1200, RoleType.ADMIN, VdcObjectType.Network, true, ApplicationMode.VirtOnly), Line 109: CONFIGURE_NETWORK_VNIC_PROFILE(1203, RoleType.ADMIN, VdcObjectType.Network, true), Line 110: CREATE_NETWORK_VNIC_PROFILE(1204, RoleType.ADMIN, VdcObjectType.Network, true), Line 111: DELETE_NETWORK_VNIC_PROFILE(1205, RoleType.ADMIN, VdcObjectType.Network, true), the subject entity should VnicProfile rather than Network Line 112: Line 113: // Login action group Line 114: LOGIN(1300, RoleType.USER, VdcObjectType.Bottom, false), Line 115: .................................................... File backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties Line 7: VdsSpmIdMapDAO=org.ovirt.engine.core.dao.VdsSpmIdMapDAODbFacadeImpl Line 8: AuditLogDAO=org.ovirt.engine.core.dao.AuditLogDAODbFacadeImpl Line 9: InterfaceDao=org.ovirt.engine.core.dao.network.InterfaceDaoDbFacadeImpl Line 10: VmNetworkInterfaceDao=org.ovirt.engine.core.dao.network.VmNetworkInterfaceDaoDbFacadeImpl Line 11: VmNetworkInterfaceProfileDao=org.ovirt.engine.core.dao.network.VmNetworkInterfaceProfileDaoImpl s/VmNetworkInterfaceProfileDaoImpl/VmNetworkInterfaceProfileDaoDbFacadeImpl Line 12: VmNetworkStatisticsDao=org.ovirt.engine.core.dao.network.VmNetworkStatisticsDaoDbFacadeImpl Line 13: LunDAO=org.ovirt.engine.core.dao.LunDAODbFacadeImpl Line 14: RoleGroupMapDAO=org.ovirt.engine.core.dao.RoleGroupMapDAODbFacadeImpl Line 15: VmTemplateDAO=org.ovirt.engine.core.dao.VmTemplateDAODbFacadeImpl -- To view, visit http://gerrit.ovirt.org/15992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0525a6d30995fe896499fed283638b93cae5e41 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
