Eli Mesika has posted comments on this change.

Change subject: [WIP] core: Add vnic profiles to DB and entities
......................................................................


Patch Set 13: (1 inline comment)

....................................................
File packaging/dbscripts/network_sp.sql
Line 75:        -- Get (and keep) a shared lock with "right to upgrade to 
exclusive"
Line 76:        -- in order to force locking parent before children
Line 77:    select   id INTO v_val FROM network  WHERE id = v_id     FOR UPDATE;
Line 78: 
Line 79:    DELETE FROM vnic_profiles
This must be done with a FK + DELETE ON CASCADE
Line 80:    WHERE network_id = v_id;
Line 81: 
Line 82:    DELETE FROM network
Line 83:    WHERE id = v_id;


-- 
To view, visit http://gerrit.ovirt.org/15992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0525a6d30995fe896499fed283638b93cae5e41
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to