Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: allow invalid fqdn in non interactive mode ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 14: 1. in upgrade we need to accept whatever host name existed during setup. Line 15: this is easy to solve by activating validation only for setup. Line 16: Line 17: 2. user who specify host name via cmd-line should know what he is doing, Line 18: we cannot enforce our decision over. I tend to disagree that admin can have typo, in such case he will clean up the environment and install again. if you use non interactive installation you probably know what you are doing, or you should not do so, there are 1000 other issues that can go wrong. I do understand that adding a new variable is a solution, I've considered it, however, this mean that we need to have such variable for every variable if we would like to be consistent. The reverse resolve we do is a service to the user... not the target... Line 19: Line 20: this change will produce error during non interactive setup, but will Line 21: allow setup to continue. Line 22: -- To view, visit http://gerrit.ovirt.org/16543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6c80ac47d55ade01dd6a3472e950d2c0ffa0074 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
