Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: allow invalid fqdn in non interactive mode ......................................................................
packaging: setup: allow invalid fqdn in non interactive mode in interactive mode we allow user to retry and correct invalid host name, in non interactive mode we simply fail installation. there are two reasons why we should not fail installation: 1. in upgrade we need to accept whatever host name existed during setup. this is easy to solve by activating validation only for setup. 2. user who specify host name via cmd-line should know what he is doing, we cannot enforce our decision over. this change will produce error during non interactive setup, but will allow setup to continue. Change-Id: Ic6c80ac47d55ade01dd6a3472e950d2c0ffa0074 Signed-off-by: Alon Bar-Lev <[email protected]> Reported-By: Michael Pasternak <[email protected]> --- M packaging/setup/plugins/ovirt-engine-setup/config/hostname.py 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6c80ac47d55ade01dd6a3472e950d2c0ffa0074 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
