Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: allow invalid fqdn in non interactive mode ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 14: 1. in upgrade we need to accept whatever host name existed during setup. Line 15: this is easy to solve by activating validation only for setup. Line 16: Line 17: 2. user who specify host name via cmd-line should know what he is doing, Line 18: we cannot enforce our decision over. Well in this specific case I want to avoid that the admin reach an inevitable failure at the end of the execution of the setup, after having changed files on disk, if he specify an unresolvable fqdn and setting up aio when we can detect it at validation stage before touching the disc content. In general, I would like to stop the setup before touching the disk if setup knows that something will lead to an error for sure. About the variable for skipping the check, I can agree to add it for development use or debugging a later stage. Line 19: Line 20: this change will produce error during non interactive setup, but will Line 21: allow setup to continue. Line 22: -- To view, visit http://gerrit.ovirt.org/16543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6c80ac47d55ade01dd6a3472e950d2c0ffa0074 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
