Sandro Bonazzola has posted comments on this change. Change subject: pki: Allow changing the manager hostname ......................................................................
Patch Set 16: (2 inline comments) .................................................... Commit Message Line 6: Line 7: pki: Allow changing the manager hostname Line 8: Line 9: Added a script bin/ovirt-engine-rename-manager-host that does Line 10: some of the work required to change the manager's hostname. Looking at the commit message I don't know what's missing here. If it just do some of the work what need to be done then? Line 11: Line 12: Change-Id: Ifb03d638be1e030865d3ebabaa163ca9be9e70ce .................................................... File packaging/bin/ovirt-engine-rename-manager-host.sh Line 159: local groupnumfile Line 160: Line 161: local group='' Line 162: local description='' Line 163: local optional='' the parsing here seems a bit complicated but it's ok for me. If you have time I can suggest to take a look at - https://github.com/rudimeier/bash_ini_parser/blob/master/read_ini.sh - http://ajdiaz.wordpress.com/2008/02/09/bash-ini-parser/ It would have been simpler in python. Line 164: cat "${ENGINE_UNINSTD}"/*.conf | while read line; do Line 165: if echo "${line}" | grep -q '^\[file_group'; then Line 166: group=$(echo "${line}" | sed -ne 's/^\[file_group_\([^]]*\)\].*/\1/p') Line 167: elif echo "${line}" | grep -q '^\['; then -- To view, visit http://gerrit.ovirt.org/16404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb03d638be1e030865d3ebabaa163ca9be9e70ce Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
