Yedidyah Bar David has posted comments on this change.
Change subject: pki: Allow changing the manager hostname
......................................................................
Patch Set 16: (2 inline comments)
....................................................
Commit Message
Line 6:
Line 7: pki: Allow changing the manager hostname
Line 8:
Line 9: Added a script bin/ovirt-engine-rename-manager-host that does
Line 10: some of the work required to change the manager's hostname.
It does everything it's supposed to do (IMO).
The rest should be done by the user according to an article we should publish.
Line 11:
Line 12: Change-Id: Ifb03d638be1e030865d3ebabaa163ca9be9e70ce
....................................................
File packaging/bin/ovirt-engine-rename-manager-host.sh
Line 159: local groupnumfile
Line 160:
Line 161: local group=''
Line 162: local description=''
Line 163: local optional=''
Nice indeed, but it's bash. I use only sh. Personally I also find it quite
complex too, although well-commented.
I already told Alon (in private) that if he has too many comments I'll rewrite
in python...
Line 164: cat "${ENGINE_UNINSTD}"/*.conf | while read line; do
Line 165: if echo "${line}" | grep -q '^\[file_group'; then
Line 166: group=$(echo "${line}" | sed -ne
's/^\[file_group_\([^]]*\)\].*/\1/p')
Line 167: elif echo "${line}" | grep -q '^\['; then
--
To view, visit http://gerrit.ovirt.org/16404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb03d638be1e030865d3ebabaa163ca9be9e70ce
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
