Vojtech Szocs has posted comments on this change.
Change subject: userportal,webadmin: Frontend refactor
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(2 inline comments)
Looks good to me but there's still an open question in
FrontendEventsHandlerImpl.java
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
Line 161: }
Line 162: failureEventHandler(errorMessage);
Line 163: }
Line 164:
Line 165: static UIConstants getConstants() {
I think this is already done via "static UIConstants constants" (?)
I guess the purpose of this getter is to avoid doing
"ConstantsManager.getInstance().getConstants()" upon static field (class)
initialization.
Line 166: if (constants == null) {
Line 167: constants = ConstantsManager.getInstance().getConstants();
Line 168: }
Line 169: return constants;
Line 386: (ArrayList<VdcQueryParametersBase>) queryParamsList,
Line 387: new AsyncCallback<ArrayList<VdcQueryReturnValue>>() {
Line 388: @Override
Line 389: public void onFailure(final Throwable caught) {
Line 390: try {
I think "callback.executed(f)" can potentially throw exception at runtime, and
I think Alex wanted to make sure "raiseQueryCompleteEvent" is called regardless
of any exceptions.
Line 391: if (ignoreFailure(caught)) {
Line 392: return;
Line 393: }
Line 394: logger.log(Level.SEVERE, "Failed to execute
RunPublicQuery: " + caught, caught); //$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/15399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dae5a455ad16660b97cddafba53b53d3b4196f1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
