Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: Frontend refactor ......................................................................
Patch Set 6: (1 inline comment) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java Line 48 Line 49 Line 50 Line 51 Line 52 > I traced all the invocations ... including ones that ended up in some failures, I assume? again - invocations that end successfully will indeed *always* result in an empty "faults". also: what happens today when a RunMultipleAction invocation ends up is some failures? do we see an error dialog in the GUI with all of the relevant error messages? [if so, then there is a chance that we are "reading" the "faults" data someplace else, and we indeed don't need it here; otherwise - we have a bug] -- To view, visit http://gerrit.ovirt.org/15399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dae5a455ad16660b97cddafba53b53d3b4196f1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
