Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: Frontend refactor ......................................................................
Patch Set 6: (1 inline comment) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java Line 48 Line 49 Line 50 Line 51 Line 52 IIRC, when RunMultipleAction was invoked, the faults array-list would have been empty if the RunMultipleAction succeeded for all of its "instances" (which was usually the case, I guess). But if there were failures (one or more), the failures information would have been entered into the faults array list. I *strongly* recommend to test it (i.e. temporarily change one of the backend's commands to fail on the CanDoAction stage, for example, and invoke this command via RunMultipleAction and see what happens); In any case, as far as I can remember, we should generally support it (i.e. the error messages for the failed instances of the RunMultipleAction invocation should be displayed in an error dialog in the GUI); if, for some reason, this is not the behavior - it sounds like a bug to me. -- To view, visit http://gerrit.ovirt.org/15399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dae5a455ad16660b97cddafba53b53d3b4196f1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
