Daniel Erez has posted comments on this change.
Change subject: webadmin: support Memory Balloon
......................................................................
Patch Set 3: (3 inline comments)
....................................................
Commit Message
Line 7: webadmin: support Memory Balloon
Line 8:
Line 9: Add UI support for memory balloon device
Line 10:
Line 11: Adding Memory Balloon support in webadmin
redundant line?
Line 12: Change-Id: I3ce357b592a825e0ab96290848aa4f4cb3e20ace
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
Line 194: updateConsoleDevice(getVm().getId());
Line 195:
Line 196:
getModel().getVncKeyboardLayout().setSelectedItem(vm.getVncKeyboardLayout());
Line 197:
Line 198: Frontend.RunQuery(VdcQueryType.IsBalloonEnabled, new
IdQueryParameters(getVm().getId()), new AsyncQuery(this,
can't you use a ConfigurationValue instead?
Line 199: new INewAsyncCallback() {
Line 200: @Override
Line 201: public void onSuccess(Object model, Object
returnValue) {
Line 202:
getModel().getMemoryBalloonDeviceEnabled().setEntity(((VdcQueryReturnValue)returnValue).getReturnValue());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
Line 98:
Line 99: public class VmListModel extends VmBaseListModel<VM> implements
ISupportSystemTreeContext, UserSelectedDisplayProtocolManager
Line 100: {
Line 101:
Line 102: public static final Version BALLOON_DEVICE_MIN_VERSION = new
Version(3, 2);
why using a constant and not a ConfigurationValue?
Line 103: private UICommand newVMCommand;
Line 104:
Line 105: public UICommand getNewVmCommand() {
Line 106: return newVMCommand;
--
To view, visit http://gerrit.ovirt.org/17201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ce357b592a825e0ab96290848aa4f4cb3e20ace
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
