Daniel Erez has posted comments on this change.

Change subject: webadmin: support Memory Balloon
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
Line 98: 
Line 99: public class VmListModel extends VmBaseListModel<VM> implements 
ISupportSystemTreeContext, UserSelectedDisplayProtocolManager
Line 100: {
Line 101: 
Line 102:     public static final Version BALLOON_DEVICE_MIN_VERSION = new 
Version(3, 2);
How is it different from other features that are supported only from 3.2? E.g. 
NetworkLinkingSupported/HardwareInfoEnabled/etc.
Line 103:     private UICommand newVMCommand;
Line 104: 
Line 105:     public UICommand getNewVmCommand() {
Line 106:         return newVMCommand;


-- 
To view, visit http://gerrit.ovirt.org/17201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ce357b592a825e0ab96290848aa4f4cb3e20ace
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to