Doron Fediuck has posted comments on this change.
Change subject: webadmin: support Memory Balloon
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
Line 98:
Line 99: public class VmListModel extends VmBaseListModel<VM> implements
ISupportSystemTreeContext, UserSelectedDisplayProtocolManager
Line 100: {
Line 101:
Line 102: public static final Version BALLOON_DEVICE_MIN_VERSION = new
Version(3, 2);
It seems that there are 2 ways to handle this today.
One is the suggested way, and yours is the other way.
If you'll check VmModelBehaviorBase.java you'll see there's
boolean clusterSupportsHostCpu =
getModel().getSelectedCluster() != null
&&
(getModel().getSelectedCluster()).getcompatibility_version()
.compareTo(Version.v3_2) >= 0;
(there are other cases as well).
So we can decide we wish to work with only one of the options,
but it should be properly discussed and announced in the devel list.
So this patch should not become a victim of an opinion, rather than follow a
convention.
Line 103: private UICommand newVMCommand;
Line 104:
Line 105: public UICommand getNewVmCommand() {
Line 106: return newVMCommand;
--
To view, visit http://gerrit.ovirt.org/17201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ce357b592a825e0ab96290848aa4f4cb3e20ace
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
