Maor Lipchuk has posted comments on this change.
Change subject: engine: StorageConnections ops won't assume VDS/SP
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
Line 102: if (isConnWithSameDetailsExists(paramConnection)) {
Line 103: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_CONNECTION_ALREADY_EXISTS);
Line 104: }
Line 105:
Line 106: if (!Guid.isNullOrEmpty(getParameters().getVdsId())) {
please add a comment here
Line 107: if (getVds() == null) {
Line 108: return
failCanDoAction(VdcBllMessages.VDS_INVALID_SERVER_ID);
Line 109: }
Line 110: if (getVds().getStatus() != VDSStatus.Up) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java
Line 30: VDSCommandType.DisconnectStorageServer,
Line 31: new
StorageServerConnectionManagementVDSParameters(getParameters().getVdsId(),
Guid.Empty,
Line 32:
getParameters().getStorageServerConnection().getstorage_type(),
Line 33: new ArrayList<>(Arrays
Line 34: .asList(new
StorageServerConnections[]{getConnection()})))).getSucceeded();
the Curly brackets should have a space before and after
"[]{getConnection(" --> "[] { getConnection("
Line 35: }
Line 36:
--
To view, visit http://gerrit.ovirt.org/17288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I628bf2a63f64d3acaa3520ad144e1eef744f1204
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
