Liron Ar has posted comments on this change.
Change subject: engine: StorageConnections ops won't assume VDS/SP
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 190: }
Line 191:
Line 192: @Override
Line 193: protected void executeCommand() {
Line 194: boolean isDomainUpdatePossible =
!Guid.isNullOrEmpty(getVdsId());
I'd remove this boolean, it seems clear enough to me with this inline.
Line 195: boolean isDomainUpdateRequired = isDomainUpdatePossible &&
doDomainsUseConnection(getConnection());
Line 196: List<StorageDomain> updatedDomains = new ArrayList<>();
Line 197: boolean hasConnectStorageSucceeded = false;
Line 198: if (isDomainUpdateRequired) {
Line 243: return !getLuns().isEmpty();
Line 244: }
Line 245:
Line 246: protected Collection<StoragePoolIsoMap>
getStoragePoolIsoMap(StorageDomain storageDomain) {
Line 247: return
getStoragePoolIsoMapDao().getAllForStorage(storageDomain.getId());
perhaps add here caching, it's being called 3 times. whatever you prefer
Line 248: }
Line 249:
Line 250: protected void changeStorageDomainStatusInTransaction(final
StorageDomainStatus status) {
Line 251: executeInNewTransaction(new TransactionMethod<Void>() {
--
To view, visit http://gerrit.ovirt.org/17288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I628bf2a63f64d3acaa3520ad144e1eef744f1204
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
