Daniel Erez has posted comments on this change.
Change subject: engine: StorageConnections ops won't assume VDS/SP
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 251: executeInNewTransaction(new TransactionMethod<Void>() {
Line 252: @Override
Line 253: public Void runInTransaction() {
Line 254: CompensationContext context =
getCompensationContext();
Line 255: for (StorageDomain domain : domains) {
are we sure that 'domains' and 'getStoragePoolIsoMap(domain)' are not null?
Line 256: for (StoragePoolIsoMap map :
getStoragePoolIsoMap(domain)) {
Line 257: context.snapshotEntityStatus(map,
map.getstatus());
Line 258: updateStatus(map, status);
Line 259: }
--
To view, visit http://gerrit.ovirt.org/17288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I628bf2a63f64d3acaa3520ad144e1eef744f1204
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
