Vojtech Szocs has posted comments on this change. Change subject: HostGeneralModel: improve "node has upgrade" logic ......................................................................
Patch Set 9: Looks good to me, approved I agree with Alon that we should get rid of regexp stuff in compat RpmVersion, so that we can delete UI's custom (gwt-extension) RpmVersion implementation and just use compat RpmVersion. Regarding String.format usage in client code, resulting (JavaScript) implementation is not very efficient and therefore we try to avoid String.format in client code. For simple concatenation we use "+" and for more complex concatenation we use StringBuilder which is implemented via native (JavaScript) string array. -- To view, visit http://gerrit.ovirt.org/16089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
